Repository navigation
Move the Voice Samples to @sentdm/voice-client 0.2.0 and /v3/voice - #2
Merged
Merged
Conversation
@sentdm/voice is deprecated. The samples now use @sentdm/voice-client, and the feature tour its React bindings from @sentdm/voice-client-react. Voice tokens are minted with POST /v3/voice/tokens, and the call commands live under /v3/voice/calls. - Feature tour: the SDK sends its own requests to Sent, the exchange of the opaque vt_ token and the telemetry batches, under its baseURL. By default that is the app's SDK relay at /api/sdk-relay, which replaces the telemetry relay. It forwards any SDK request under /v3/voice/ to the configured API base URL and records only the telemetry batches. The service worker is copied from @sentdm/voice-client/sw.js. - Inbound and outbound agents: rebuilt dist/. Their third-party notices now carry the notices voice-client ships for the code it bundles. - Chat + voice agent: @sentdm/sentdm 0.46.0, whose voice.tokens.create replaces channels.voice.createToken. - Both Next.js samples: a temporary Turbopack loader turns off the AMD branches in the voice client's bundled calling library, which name files the package does not ship and fail the build. It goes once @sentdm/voice-client 0.2.1 is installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the Voice Samples to @sentdm/voice-client 0.2.0 and /v3/voice
Changes / Fixes / Features included
This PR includes changes / features as below:
@sentdm/voice0.1.x to@sentdm/voice-client0.2.0 (plus@sentdm/voice-client-reactin the feature tour). They also move to the/v3/voiceAPI that is in prod since services #2441:/v3/voice/tokens, as opaquevt_…strings the SDK exchanges itself;/v3/voice/calls*;@sentdm/voice-client/sw.js.baseURL;/v3/callspath in the API console, the proxy allowlist and the call screens is updated;app/api/sdk-relay, option "SDK requests to Sent"). 0.2.0 dropstelemetry.baseURL, so the token exchange goes through the same relay. It forwards anything underv3/voice/, with a 15 s timeout, and records only telemetry batches, never the exchange.@sentdm/sentdm0.44 → 0.46 forvoice.tokens.create.dist/andTHIRD_PARTY_NOTICES.mdare rebuilt. 0.2.0 bundles its provider, so its own notices file is appended.define([...])branches that Turbopack fails on (114 "Can't resolve './core'"). Both Next.js samples carry a small loader that disables them, marked for removal once@sentdm/voice-client0.2.1 is installed. The fix is Drop the bundled provider's AMD branches, which fail Next.js builds with Turbopack sent-dm-voice-typescript#12.Part of EPIC-4426 (Sent Voice): https://github.com/sentdm/sent-dm-agentic-org/blob/main/_pm/epics/EPIC-4426-sent-voice.md
How to test?
In order to test changes included in the PR follow steps as below:
check,test,buildand (inbound/outbound)test:browserandtest:dashboard. All pass, and the tree is clean after the builds/phone. Registration should go through the SDK relay, and the Telemetry tab should list batches but not the token exchange/v3/voice/calls