Repository navigation
Publish once per release, and treat a version another run just published as done - #14
Merged
Merged
Conversation
…blished as done release-please publishes three GitHub releases for one linked version, so publish-npm ran three times for 0.2.1. The first published all three packages; the queued one after it still saw voice-client-core 0.2.1 as missing, because the registry lagged, tried again and failed with E409. Only voice-client's release now runs the job, and the other two are skipped. bin/publish-npm checks with --prefer-online, and when a publish fails it looks again for up to 30 seconds before failing, so a version that is already there counts as published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The red
publish-npmrun on 0.2.1 is a duplicate run, not a failed release. All three packages are on npm at 0.2.1, published by the first run, and the bundle fix is in the tarball.What happened. release-please published three GitHub releases at 22:30, one per linked package, so
publish-npmwas triggered three times:voice-client-core,voice-clientandvoice-client-react0.2.1 over OIDC. This is the first automatic trusted publish that worked.publish-npmconcurrency group.npm viewstill answered "not published" forvoice-client-core@0.2.1, because the registry lagged, so it tried to publish and npm refused withE409 Cannot publish over previously staged version.Fix:
publish-npm.yml: only voice-client's release runs the job; the other two show as skipped. That's enough because the three share one version andbin/publish-npmpublishes every package whose version is new. The concurrency group stays, for a manual run that overlaps one.bin/publish-npm:--prefer-online;I tested the loop with stubbed
npmandpnpm: the first package fails with E409 and is found on the second check, then the second package publishes, and the run exits 0.The
ci:commit makes no release.