Remove dead genebody coverage code#24
Merged
Merged
Conversation
The old GenebodyCoverageAccum/TranscriptPositionMap code ran in the counting hot loop but its output (CountResult.genebody) was never read or written anywhere — fully replaced by the qualimap module. Removes ~540 lines of dead computation including the genebody.rs module, config, parameters, and all hot-loop accumulation calls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for rustqc canceled.
|
… issues Remove populated-but-never-consumed fields: mapq_distribution and primary_paired from BamStat, fragment_count/transcript_coverage/ merged_gene_coverage from QualimapResult, and supporting accumulator code. Remove unused ExonMeta.transcript_idx, MergedGeneModel.gene_idx/ exonic_length, QualimapIndex.num_genes/merged_gene_models, and TranscriptCoverage::iter(). Fix incorrect dead_code annotations with accurate comments. Fix clippy issues: .clone() on Copy types, unnecessary cast, useless vec! in tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove orphaned doc comment for a previously deleted function that was causing clippy doc_lazy_continuation errors. Run cargo fmt. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
The follow-up commits (622319e, 6bd8064) go beyond the original genebody removal and clean up additional dead code and issues found across the codebase: Removed unused fields
Fixed incorrect
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenebodyCoverageAccum/TranscriptPositionMapcode that was computed in the counting hot loop but whose output (CountResult.genebody) was never read or written anywhere#[allow(dead_code)]and docs already called it "legacy"Test plan
cargo build— compiles cleanlycargo test— all 184 tests pass (172 unit + 12 integration)cargo clippy— no new warnings (4 pre-existing doc indentation warnings in unrelated code)🤖 Generated with Claude Code