updated four notebooks to version 0.2.0 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jspaaks
reviewed
Apr 8, 2021
There was a problem hiding this comment.
Don't forget to update
Line 1 in 9e4c5f0
Also won't need the 'install git' instruction anymore
I followed the install instructions and reran all notebooks, everything seems to be working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #16 and sequgen issue #77
Description
The sequgen functions changed in release 0.2.0 (see sequgen issue #73) and therefore four notebooks required an update:
triangular_peak'splacementparameter was renamedlocationtriangular_peakandnormal_peaklost the parametersignboxcarwas addedTo test
Install the notebooks and verify that they work