Skip to content

Conversation

@prathameshmm02
Copy link
Contributor

@prathameshmm02 prathameshmm02 commented Sep 21, 2025

Add support for React Native 0.81, contains following fixes:

  • Upgrade libsodium to 1.0.20 (contains 16KB alignment fix for libsodium.so)
  • Enable 16KB native library alignment
  • Update C++ standard to C++20 in CMakeLists.txt
  • Fix an issue due to folly dep when prebuild RN deps are enabled

@landabaso
Copy link
Contributor

Signature verification fails.
The signature file does not match [the one distributed in the original repo]
/cc @nikgraf

@landabaso
Copy link
Contributor

landabaso commented Sep 25, 2025

I’m on RN 0.79.5. This PR fixes Folly deps by adding:

if ENV['RCT_USE_RN_DEP'] != '1'
  s.dependency 'RCT-Folly', folly_version
end

However, pod install fails with:

[!] Invalid `react-native-libsodium.podspec` file: undefined local variable or method `folly_version' for module Pod.

Suggestion: drop the variable and rely on CocoaPods resolution:

s.dependency 'RCT-Folly'

This works on RN 0.79.5. Not sure about 0.8x.
/cc @nikgraf

@prathameshmm02
Copy link
Contributor Author

Removed folly_version, oh my mindless copy pasting. Also timestamp of the signature file is 1758756827 (25th September), it was recently updated, current version's (1.0.19) signature also does not match btw.

@landabaso
Copy link
Contributor

Thanks @prathameshmm02. Why not update the .minisig file as well? The script downloads the latest .tar.gz, and without the matching signature it won't be able to proceed. The tar.gz file has changed since your initial commit.

@howardleejh
Copy link

Hi, following up on this, is it still in progress?

@prathameshmm02
Copy link
Contributor Author

Waiting on @nikgraf to review this.

@tgreco
Copy link

tgreco commented Oct 17, 2025

Thanks @prathameshmm02. Why not update the .minisig file as well? The script downloads the latest .tar.gz, and without the matching signature it won't be able to proceed. The tar.gz file has changed since your initial commit.

@prathameshmm02 whats your thoughts on this question? I think it's a valid concern

@prathameshmm02
Copy link
Contributor Author

prathameshmm02 commented Oct 17, 2025

Libsodium tarballs update frequently, I can't keep updating the build, it might update next week, last update was today.

Note: Check the timestamp in the minisig file not in the index of releases.

@nikgraf
Copy link
Member

nikgraf commented Nov 1, 2025

Looks good, thanks for fixing! Will update the minisig and signature myself afterwards

@nikgraf nikgraf self-requested a review November 1, 2025 20:53
@nikgraf nikgraf merged commit bd45ebf into serenity-kit:main Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants