-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TelemetryConfiguration.Active #206
base: dev
Are you sure you want to change the base?
Conversation
According to Microsoft in this PR (microsoft/ApplicationInsights-dotnet#1148) they recommend using Telemetry.CreateDefault().
Thanks for the heads-up. I think we should probably remove this example entirely - the only really useful way to configure this sink currently is with a connection string or via injection of the telemetry client through DI, IIRC 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add (follow here):
[Obsolete("We do not recommend using TelemetryConfiguration.Active on .NET Core. See https://github.com/microsoft/ApplicationInsights-dotnet/issues/1152 for more details")]
With #NETSTANDARD
, like here: https://github.com/microsoft/ApplicationInsights-dotnet/blob/c9d420224a06d27ee74fba4b41cad7460bd63bd0/BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs#L40
// TelemetryConfiguration.Active is obsolete | ||
// https://github.com/microsoft/ApplicationInsights-dotnet/pull/1148 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// TelemetryConfiguration.Active is obsolete | |
// https://github.com/microsoft/ApplicationInsights-dotnet/pull/1148 |
No need to add this for readme
// TelemetryConfiguration.Active is obsolete | ||
// https://github.com/microsoft/ApplicationInsights-dotnet/pull/1148 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// TelemetryConfiguration.Active is obsolete | |
// https://github.com/microsoft/ApplicationInsights-dotnet/pull/1148 |
No need to add this for readme
@nblumhardt: I'm still using this style of configuring logger and output template. |
According to Microsoft in this PR (microsoft/ApplicationInsights-dotnet#1148) they recommend using Telemetry.CreateDefault().