Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TelemetryConfiguration.Active #206

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

idrivediesel2006
Copy link

According to Microsoft in this PR (microsoft/ApplicationInsights-dotnet#1148) they recommend using Telemetry.CreateDefault().

According to Microsoft in this PR (microsoft/ApplicationInsights-dotnet#1148) they recommend using Telemetry.CreateDefault().
@nblumhardt
Copy link
Contributor

Thanks for the heads-up. I think we should probably remove this example entirely - the only really useful way to configure this sink currently is with a connection string or via injection of the telemetry client through DI, IIRC 🤔

Copy link

@Saibamen Saibamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +13 to +14
// TelemetryConfiguration.Active is obsolete
// https://github.com/microsoft/ApplicationInsights-dotnet/pull/1148

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TelemetryConfiguration.Active is obsolete
// https://github.com/microsoft/ApplicationInsights-dotnet/pull/1148

No need to add this for readme

Comment on lines +23 to +24
// TelemetryConfiguration.Active is obsolete
// https://github.com/microsoft/ApplicationInsights-dotnet/pull/1148

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TelemetryConfiguration.Active is obsolete
// https://github.com/microsoft/ApplicationInsights-dotnet/pull/1148

No need to add this for readme

@Saibamen
Copy link

I think we should probably remove this example entirely

@nblumhardt: I'm still using this style of configuring logger and output template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants