Add tests for large cell logging in Azure Sink #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two new test methods to the `AzureTableStorageWithPropertiesSinkTests` class to address scenarios involving logging entries that exceed Azure Table Storage's cell size limit using Serilog. The first test, `WhenALoggerWritesToTheSinkAndACellExceeds32KAnExceptionIsRaised`, verifies that an exception is thrown when a log entry exceeds the 32K character limit, noting the test is skipped for the Storage Emulator due to its different limit constraints. The second test, `WhenALoggerWritesToTheSinkAndACellExceeds32KAnExceptionIsRaisedButSubsequentCallsContinueToWorkAsExpected`, checks that after an oversized entry throws an exception, subsequent log entries are processed normally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Azure Table Sink silently fails when attempting to add more than 64K of data (32K string) to a cell. All subsequent logging also stops working even if this limit is not exceeded.
Added two new test methods to the
AzureTableStorageWithPropertiesSinkTestsThe first test,WhenALoggerWritesToTheSinkAndACellExceeds32KAnExceptionIsRaised, verifies that an exception is thrown when a log entry exceeds the 32K character limit, noting the test is skipped for the Storage Emulator due to its different limit constraints. The second test,WhenALoggerWritesToTheSinkAndACellExceeds32KAnExceptionIsRaisedButSubsequentCallsContinueToWorkAsExpected, checks that after an oversized entry throws an exception, subsequent log entries are processed normally.