Add an "allocator_api" feature #387
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was there ever a vision articulated for this feature? While I believe that the feature is supposed to behave as it does is in this PR, it also mandates a couple of compromises. |
|
Sorry for the delay in reviewing this. Just wanted to let you know this is still on my to-do list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should cross out the last item in the wishlist (#183).
If the feature is enabled, the
SmallVectype gets another type parameter for the allocator and makes use of the nightly Rust "allocator_api" feature. Additional allocator-based functions also become available, including the non-standardfrom_slice_inthat mimics the
to_vec_infunction in Rust.