Fixed a infinite loop, updated libQuic, disabled MTU discovery and C API tweaks #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 3 changes:
Fixed an infinite loop when refreshing the snode cache
We weren't defaulting the
in_progress_snode_cache_refresh_count
to0
which meant whenNetwork::refresh_snode_cache
was called the recursive logic below would be called and whenin_progress_snode_cache_refresh_count
evaluated to a negative value it would just recurse endlesslyBy defaulting the value to
0
this should no longer occurUpdated libQuic and disabled MTU discovery
Updated to the latest version of
libQuic
which adds the option to disable MTU discovery, this has been added to the network instance for the time being (in the future it'd be good to try to fix this a different way)C API Tweaks
Updated a number of the C functions to take
const char* const*
instead ofconst char**