Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startup if scheme is missing in server URL #34

Merged
merged 1 commit into from
May 21, 2024

Conversation

seternate
Copy link
Owner

If the scheme in the server URL is missing 'http' is added as default scheme and the url is parsed again. With this behaviour the user does not need to enter the scheme if it would be 'http'.

Fixes: #4

If the scheme in the server URL is missing 'http' is added as default
scheme and the url is parsed again. With this behaviour the user does
not need to enter the scheme if it would be 'http'.
@seternate seternate self-assigned this May 21, 2024
@seternate seternate added this to the v0.2.0 milestone May 21, 2024
@seternate seternate merged commit 7e0d60c into main May 21, 2024
2 checks passed
@seternate seternate deleted the fix-app-startup-wrong-encoded-server-url branch May 21, 2024 18:51
@seternate seternate linked an issue May 24, 2024 that may be closed by this pull request
@seternate seternate added the bug Something isn't working label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] App does not start if server URL misses http [FEATURE] Support multiple ways to specify the server URL
1 participant