Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thread config in nx-vite build and serve #60

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sledorze
Copy link

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2021

🦋 Changeset detected

Latest commit: 9419e0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wanews/nx-vite Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

const vite = execa(
packageManager.exec,
['vite', `${tree.root}/${appRoot}`, '--open'],
['vite', root, '--config', configFile ,'--open'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the config file doesn't exist, does that cause an issue?

Also, doesn't vite.config.js get picked up by convention?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants