-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Credential struct to daemon_stub.go and daemon_unix.go #92
base: master
Are you sure you want to change the base?
Conversation
…er and group identities
Doesn't work on macos
|
Do you run it from root? |
No |
@skrashevich, i don't understand what purpose of the changes. Could you provide me more context or example? |
because |
Uid: d.Credential.Uid, | ||
Gid: d.Credential.Gid, | ||
Groups: d.Credential.Groups, | ||
NoSetGroups: d.Credential.NoSetGroups, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential nil pointer dereference.
The PR changes public interface of the library and breaks backward compatibility. |
..for ability to compile the same code for windows and *nix systems