Skip to content

Security Issue: XSS vulnerability in modal_helper:close_button #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Security Issue: XSS vulnerability in modal_helper:close_button #906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/helpers/modal_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ def modal_footer(options, &block)
end

def close_button(dismiss)
#It doesn't seem to like content_tag, so we do this instead.
raw("<button class=\"close\" data-dismiss=\"#{dismiss}\" aria-hidden=\"true\">&times;</button>")
content_tag :button, '&times;'.html_safe, { :class => 'close', "data-dismiss" => dismiss, "aria-hidden" => true }
end

def modal_toggle(content_or_options = nil, options, &block)
Expand Down