Add kTLS options and SSL_sendfile #2203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to enable OpenSSL kTLS, but since all current downstream libs do not support sendfile, I only tested that kTLS works.
The crate's SslStream also does not support kTLS, because it does not directly pass the socket to OpenSSL.
If anyone wants to use kTLS must create a BIO using BIO_new_socket through openssl-sys and write own SslStream.
Note:
During my testing, OpenSSL 3.2 seemed to cause a memory leak when kTLS was enabled but not supported by the kernel, but I could not find any relevant bug reports.
I tried downgrading to OpenSSL 3.1 and the memory leak no longer occurred.
The memory leak also did not occur in OpenSSL 3.2 without kTLS enabled.