Update ctest dependency from 0.4.11 to 0.5.0-beta.0 to support new target architecture #2460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once there's a stable ctest 0.5 release, I'll be happy to review+merge. Thanks! |
|
FYI: there's a merge conflict here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
ctestdependency from version 0.4.11 to 0.5.0-beta.0 to address an issue wherectest0.4.11 doesn't recognize new target architectures, specifically for theriscv64a23-unknown-linux-gnutarget.With
ctest0.5.0-beta.0, this issue is resolved, but it requires modifications torust-openssl/systest/build.rsto ensure proper ABI compatibility for the new version.Error fixed:
Previous Issue: When using
ctest0.4.11, running the custom build command forsystestfailed with the error message:Solution: Upgrading to
ctest0.5.0-beta.0 fixes the issue by supporting the new target, but requires minor adjustments to thebuild.rsscript to accommodate ABI compatibility.