[Fix]Pad the last rank if vocab size is not divisible by tp_size - #100
Open
cswuyg wants to merge 5 commits into
Open
[Fix]Pad the last rank if vocab size is not divisible by tp_size#100cswuyg wants to merge 5 commits into
cswuyg wants to merge 5 commits into
Conversation
Collaborator
|
Hi @cswuyg . I wonder there's some real world use case for this PR. It seems that we have not encountered such an issue so far. In addition, we use the |
DarkSharpness
added
the
bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pad vocabulary size to a multiple of TP size to ensure shape alignment and avoid assertion errors when assigning self.weight on each TP rank.