Skip to content

Add group class to Collapsible for state change listening #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ixfloma wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

Add group class to Collapsible for state change listening #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/docs/app/patterns/components/client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,8 @@ export const CompsSidebarClient = ({ pages }: CompsSidebarClientProps) => {

return (
<Collapsible
// Seems group hasn't declared yet, this is important to listen the group-data state change
className="group/collapsible"
key={subgroup.name}
onOpenChange={(open) => {
setOpenSubgroups((prev) => {
Expand All @@ -233,7 +235,8 @@ export const CompsSidebarClient = ({ pages }: CompsSidebarClientProps) => {
<CollapsibleTrigger asChild>
<SidebarMenuButton className="capitalize">
{subgroup.name}
<ChevronDown className="ml-auto transition-transform group-data-[state=open]/collapsible:rotate-180" />
{/* this chevron group-data now listen to group/collapsible */}
<ChevronDown className="ml-auto transition-transform rotate-0 group-data-[state=open]/collapsible:-rotate-180" />
</SidebarMenuButton>
</CollapsibleTrigger>
<CollapsibleContent>
Expand Down