Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add freedesktop metadata #1495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fpiesche
Copy link
Contributor

@fpiesche fpiesche commented Nov 6, 2024

This adds a new dist directory intended for files specific to distributions rather than actually part of the code or executable/bundle, containing the Linux desktop launcher (which currently lives in the .github directory for some reason) as well as FreeDesktop metainfo.xml and releases.xml files. The XML files contain metadata that can be used by Linux desktop environments to display information about the package - this is, for example, used by Flathub for their web listings.

The releases.xml file currently needs updating manually. I'm working on a GitHub action that can automatically update these files when a new GitHub release is made; once I've done this and tested it I'll submit a PR with a workflow to keep this file up to date along with GitHub releases :)

@fpiesche
Copy link
Contributor Author

fpiesche commented Nov 6, 2024

Should I move the AppImage build scripts into the dist folder as well, and the png icon to src/images where the other icons are?

@jardon
Copy link

jardon commented Nov 7, 2024

Should I move the AppImage build scripts into the dist folder as well, and the png icon to src/images where the other icons are?

im going to say confidently, probably

Copy link

@jardon jardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should remove the change of the name field in the desktop shortcut and have that change be merged in this PR

.github/linux-appimage-qt.sh Outdated Show resolved Hide resolved
.github/linux-appimage-sdl.sh Outdated Show resolved Hide resolved
@fpiesche fpiesche force-pushed the add-freedesktop-metadata branch 2 times, most recently from b2f2340 to 35ced51 Compare November 7, 2024 21:24
@ngoquang2708
Copy link
Contributor

Update REUSE.toml for newly added/moved files or else CI will fail.

Copy link

@jardon jardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CMakeLists.txt Outdated Show resolved Hide resolved
@ngoquang2708
Copy link
Contributor

LGTM.

@jardon
Copy link

jardon commented Nov 13, 2024

@fpiesche can you resolve the conflicts so we can get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants