Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ajm: handle single-frame decode jobs (+mp3 imrovements) #1520

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ajm: handle single-frame decode jobs (+mp3 imrovements) #1520

wants to merge 3 commits into from
+442 −148

Conversation

vladmikhalin
Copy link
Collaborator

@vladmikhalin vladmikhalin commented Nov 11, 2024 •
edited
Loading

  • Break after a single frame if multi-frame decoding was not requested (fixes sound in Journey)
  • Return AJM_RESULT_NOT_ENOUGH_ROOM if no frames fit the buffer
  • mp3: implemented GetCodecInfo
  • mp3: implemented FGH OFL header parser (used by Journey)
  • Reworked gapless decoding to simplify the comprehension
  • added error logs for outstanding cases
  • minor code improvements

@vladmikhalin vladmikhalin marked this pull request as draft November 11, 2024 18:53
@vladmikhalin
Copy link
Collaborator Author

Regressed some games, putting it in draft for now.

@vladmikhalin vladmikhalin marked this pull request as ready for review November 12, 2024 17:26
@vladmikhalin vladmikhalin marked this pull request as draft November 13, 2024 16:32
@vladmikhalin vladmikhalin marked this pull request as ready for review November 13, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vladmikhalin