feat: dup & swap #18
Open
feat: dup & swap #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Cool! This is a perfectly valid approach. On the other hand I really like the simplicity of this! |
shafu0x
reviewed
Sep 24, 2023
| pub pops: usize, | ||
| pub pushes: usize, | ||
| pub swap: usize, | ||
| pub dupe: usize, |
Owner
There was a problem hiding this comment.
small detail, but I would call this dup
shafu0x
reviewed
Sep 24, 2023
| let second = &mut rest[index - 1]; | ||
| std::mem::swap(&mut first[0], second); | ||
| } else { | ||
| // Handle out of bounds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on this with a lot of help from ChatGPT. Still not working though.
Please let me know if this is the correct approach or what would be a good way to do this, I can work on it more later.