-
Notifications
You must be signed in to change notification settings - Fork 380
Migrate to shakapacker 8.4.0 #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Updated shakapacker gem from 8.2.0 to 8.4.0 - Updated shakapacker npm package from 8.2.0 to 8.4.0 - Fixed webpack configuration to preserve sass-resources-loader - Fixed path configurations for client/app structure - Added missing i18n default and translations files - Created symlinks for React on Rails compatibility - Built ReScript components - All tests passing and application working Note: Attempted migration to 9.0.0.beta.5 but encountered TypeScript compilation issues with the beta version. Will create separate PR for TypeScript conversion. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Warning Rate limit exceeded@justin808 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 57 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (24)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Quick Review App CommandsWelcome! Here are the commands you can use in this PR:
|
PR Review: Migrate to shakapacker 8.4.0Thank you for this PR! I've reviewed the migration from shakapacker 8.2.0 to 8.4.0 and have the following feedback: ✅ Positive Aspects
🔍 Issues Found1. Configuration Error in spec/rails_helper.rb (Lines 40-49)There's a duplicate RSpec configuration block that causes a syntax error:
Fix needed: Remove lines 46-49 or properly structure the RSpec.configure block. 2. Incomplete webpack configuration in serverWebpackConfig.jsThe file appears truncated at line 5 with 'const { merge, config } = requ'. This needs to be completed. 3. Missing controller and view filesNew files were added (HelloWorldController, hello_world layout) that appear to be test/example code. Consider whether these should be included in the migration or kept separate.
|
Summary
Changes Made
Notes
Test Plan
🤖 Generated with Claude Code
This change is