-
-
Notifications
You must be signed in to change notification settings - Fork 638
Switch Pro packages to public distribution #1901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ihabadham
wants to merge
7
commits into
master
Choose a base branch
from
switch-to-public-distribution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cc88d58
Switch Pro packages to public distribution
ihabadham c9b4a18
Remove @shakacode-tools scope from node-renderer package
ihabadham 32ef93d
Update documentation for public distribution
ihabadham 6b3f1c8
Update test files and source code with unscoped package name
ihabadham 33e2533
Fix package name in build script error message
ihabadham 998ca6c
Update yarn.lock for unscoped node-renderer package name
ihabadham 53ed09c
Update repository URL and add license token security warning
ihabadham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -128,7 +128,7 @@ Package [email protected] added ==> /Users/justin/shakacode/react-o | |
| Don't forget you may need to run yarn after adding packages with yalc to install/update dependencies/bin scripts. | ||
| ``` | ||
|
|
||
| Of course, you can do the same with `react-on-rails-pro` and `@shakacode-tools/react-on-rails-pro-node-renderer` packages. | ||
| Of course, you can do the same with `react-on-rails-pro` and `react-on-rails-pro-node-renderer` packages. | ||
|
|
||
| This is the approach `spec/dummy` apps use, so you can also look at their implementation. | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -347,24 +347,13 @@ Contact Justin Gordon, [[email protected]](mailto:[email protected]) for r | |
|
|
||
| ## Prerequisites | ||
|
|
||
| You need authentication for both public and private package registries: | ||
| You need authentication for public package registries: | ||
|
|
||
| **Public packages (npmjs.org + rubygems.org):** | ||
| - NPM: Run `npm login` | ||
| - RubyGems: Standard credentials via `gem push` | ||
|
|
||
| **Private packages (GitHub Packages):** | ||
| - Get a GitHub personal access token with `write:packages` scope | ||
| - Configure `~/.npmrc`: | ||
| ```ini | ||
| //npm.pkg.github.com/:_authToken=<TOKEN> | ||
| always-auth=true | ||
| ``` | ||
| - Configure `~/.gem/credentials`: | ||
| ```yaml | ||
| :github: Bearer <GITHUB_TOKEN> | ||
| ``` | ||
| - Set environment variable: `export GITHUB_TOKEN=<TOKEN>` | ||
| All React on Rails and React on Rails Pro packages are now published publicly to npmjs.org and RubyGems.org. | ||
|
|
||
| ## Release Command | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
--access publicwhen publishing the scoped renderer packageScoped npm packages default to private. On the first public release,
yarn publishwithout--access publicfails with the npm error “You must provide --access public to publish scoped packages.” That blocks the new distribution flow this PR introduces. Please append the flag (while skipping it for Verdaccio runs) so the publish step succeeds.🤖 Prompt for AI Agents