Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be optimistic with jcocoa library, in case it is already loaded. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

teras
Copy link

@teras teras commented Sep 27, 2014

Just be a little more optimisitc with native library loading, in case it is already loaded in advance with something like
System.load(".../libjcocoa.dylib");
in order to get rid of the java.library.path depedency, in case we already know the absolute library path.

@shannah
Copy link
Owner

shannah commented Sep 29, 2014

Thanks. I have some other changes in the branch "maven" that I'm planning on merging with master soon so I'm not going to merge this pull request yet. I'm going to make the equivalent change to the maven branch first.

@teras
Copy link
Author

teras commented Sep 29, 2014

If you prefer, I can make the same changes to the "maven" tree.

@shannah
Copy link
Owner

shannah commented Sep 29, 2014

Sure. That would be helpful.

@teras
Copy link
Author

teras commented Oct 16, 2014

If I am not mistaken, the maven version of the library has the binary
library inside the JAR file?
This seems to make the patch I sent you obsolete?
If the native library is already inside, then there is no reason to load it
externally.

On Mon, Sep 29, 2014 at 6:05 PM, Steve Hannah [email protected]
wrote:

Sure. That would be helpful.


Reply to this email directly or view it on GitHub
#2 (comment)
.

Panayotis Katsaloulis

@shannah
Copy link
Owner

shannah commented Oct 16, 2014

Yes. The native library is inside the jar in the maven version. I am working toward making it load automatically from the jar ... I still need to make some changes. However it still has to go through the process of extracting the library out of the jar and loading it using System.loadLibrary(), so your patch is not completely obsolete....

@teras
Copy link
Author

teras commented Oct 16, 2014

I saw that this is the same approach as what JNA does.
So extractive the native library is presumably the only easy way to do it.
:)

On Thu, Oct 16, 2014 at 10:38 PM, Steve Hannah [email protected]
wrote:

Yes. The native library is inside the jar in the maven version. I am
working toward making it load automatically from the jar ... I still need
to make some changes. However it still has to go through the process of
extracting the library out of the jar and loading it using
System.loadLibrary(), so your patch is not completely obsolete....


Reply to this email directly or view it on GitHub
#2 (comment)
.

Panayotis Katsaloulis

Copy link

@varga199 varga199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@varga199 varga199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ondolatok a JNA # 1

Copy link

@varga199 varga199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legyen optimista a jcocoa könyvtárral, ha már be van töltve.

Copy link

@varga199 varga199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be optimistic with jcocoa library, in case it is already loaded.

@uchuugaka
Copy link

Is this dead?

@shannah
Copy link
Owner

shannah commented Apr 2, 2018

Not dead. Just don't get a lot of time to work on it. I use it in quite a few of my own projects. Haven't merged this pull request, because haven't had a chance to test it.

@mojo2012
Copy link
Collaborator

mojo2012 commented Nov 3, 2019

@teras can you please merge develop into your branch and then I'll have a look at the PR.
I tried to copy your changes but the tests failed afterwards.

@Thomas-Vos
Copy link

It would be great if something like this could be merged. This would be very useful to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants