add eigen #4
Merged
add eigen #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds Eigen linear algebra library support to the project, enabling matrix multiplication operations in the C++ extension. The changes include dependency management through vcpkg, build configuration updates, and implementation of Eigen-based matrix multiplication functionality.
- Adds Eigen3 as a dependency through vcpkg configuration
- Implements
eigen_matmulfunction for matrix multiplication using Eigen - Updates build system and CI workflows to support Eigen integration
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| vcpkg.json | Adds vcpkg configuration with Eigen3, GSL, and nlopt dependencies |
| src/cpp/main.cpp | Implements Eigen-based matrix multiplication function with pybind11 bindings |
| tests/test_basic.py | Adds test case for the new Eigen matrix multiplication functionality |
| CMakeLists.txt | Updates build configuration to find and link Eigen3 library |
| pyproject.toml | Updates author email and Python version requirement |
| README.md | Adds macOS installation instructions for vcpkg and Eigen setup |
| .github/workflows/wheels.yml | Disables pull request triggers for wheel building |
| .github/workflows/test.yml | Adds vcpkg dependency management and caching to CI workflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.