Skip to content

[codex] Remove duplicate idle_poll name parameter#377

Closed
chaochaoweb3 wants to merge 2 commits into
shareAI-lab:mainfrom
chaochaoweb3:codex/remove-idle-poll-duplicate-name
Closed

[codex] Remove duplicate idle_poll name parameter#377
chaochaoweb3 wants to merge 2 commits into
shareAI-lab:mainfrom
chaochaoweb3:codex/remove-idle-poll-duplicate-name

Conversation

@chaochaoweb3

Copy link
Copy Markdown
Contributor

Summary

  • remove the redundant agent_name parameter from idle_poll
  • use name consistently for inbox polling and task claiming
  • update the only s17 call site to pass the teammate name once

Fixes #374.

Validation

  • python3 -m py_compile s17_autonomous_agents/code.py
  • git diff --check

@vercel

vercel Bot commented Jun 23, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the crazyboym's projects Team on Vercel.

A member of the Team first needs to authorize it.

The code change dropped the redundant agent_name parameter, but the
trilingual README snippets still showed the old four-arg signature, the
double-passed call site, and agent_name inside the function body
(read_inbox and claim_task). Update all three language code blocks to
the three-arg form and bump the translation-sync markers so the docs
match the code.
@Bill-Billion

Copy link
Copy Markdown
Collaborator

Thanks for the PR. I am closing this one as well, for two reasons.

First, it does not fit the teaching design here: s12's code.py is deliberately minimal, and this adds a defensive blockedBy normalization layer (json and ast.literal_eval parsing, plus type validation) and a new tests/ harness, which are production concerns the chapter is not about. If blockedBy handling genuinely confuses readers, that is better raised as an issue so we can decide how, or whether, to fold it into the lesson. Second, the same policy point as #377: we are declining bulk PRs generated by an agent and opened across many repositories at once (see CONTRIBUTING.md).

No objection to the underlying observation in #348. Feel free to keep that issue open for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

s17: idle_poll 函数存在冗余参数 agent_name

2 participants