test: restore develop CI signal#1105
Open
shaun0927 wants to merge 1 commit into
Open
Conversation
Align tests with current tab context metadata, doctor check thresholds, and tool description budget so unrelated feature PRs can rely on CI again. Constraint: This is a base-branch unblocker only; avoid carrying these fixes inside feature PRs. Rejected: Duplicating CI fixes into each feature branch | it would pollute narrowly scoped Stagehand-inspired PRs. Confidence: high Scope-risk: narrow Directive: Keep future contract changes paired with tests in the same PR to avoid hidden develop breakage. Tested: /Users/jh0927/openchrome/node_modules/.bin/tsc -p tsconfig.json --pretty false; npm run lint; npx jest --config jest.config.js --runInBand tests/tools/tabs.test.ts tests/tool-descriptions.test.ts tests/cli/doctor/checks/chrome-binary.test.ts tests/cli/doctor/checks/disk-space.test.ts tests/cli/doctor/checks/home-writable.test.ts tests/cli/doctor/checks/network-local.test.ts Not-tested: Full npm test matrix locally
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createTarget(..., isolatedContext)and context metadata contract.interactdescription while preserving required When/When NOT guidance.Scope/fit review
Validation
/Users/jh0927/openchrome/node_modules/.bin/tsc -p tsconfig.json --pretty falsenpm run lint(passes with existing warnings only)npx jest --config jest.config.js --runInBand tests/tools/tabs.test.ts tests/tool-descriptions.test.ts tests/cli/doctor/checks/chrome-binary.test.ts tests/cli/doctor/checks/disk-space.test.ts tests/cli/doctor/checks/home-writable.test.ts tests/cli/doctor/checks/network-local.test.tsMerge verification checklist