feat(observability): add recording trajectory bundles (#1059)#1117
Open
shaun0927 wants to merge 1 commit into
Open
feat(observability): add recording trajectory bundles (#1059)#1117shaun0927 wants to merge 1 commit into
shaun0927 wants to merge 1 commit into
Conversation
Constraint: Episode trajectory capture must remain default-off and observability-only so OpenChrome tool behavior does not change for normal sessions.\nRejected: A separate trajectory lifecycle tool | recording already owns episode lifecycle and a second control surface would add wandering/confusion.\nConfidence: medium\nScope-risk: moderate\nDirective: Keep trajectory writes best-effort and bounded; do not add recovery, retry, or LLM policy decisions to this core writer.\nTested: npm test -- --runInBand tests/recording/action-recorder-trajectory.test.ts tests/tools/recording.test.ts tests/recording/action-recorder.bounds.test.ts tests/tools/oc-assert.recorder-wiring.test.ts; npm run lint:changed; npm run build; npm test -- --runInBand tests/cross-env/cursor-verification.test.ts\nNot-tested: Live OpenChrome browser run with real oc_assert/oc_checkpoint artifacts
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1059.
Directionality / overlap check
oc_recording_start({ trajectoryBundle: true }).Summary
src/trajectory/.oc_assertcontract results, andoc_checkpointsaves into append-only bundle artifacts.oc_recording_statusto expose active trajectory metadata while recording is running.report.jsononoc_recording_stopwith event, tool, failure, contract, and artifact counts.Verification
npm test -- --runInBand tests/recording/action-recorder-trajectory.test.ts tests/tools/recording.test.ts tests/recording/action-recorder.bounds.test.ts tests/tools/oc-assert.recorder-wiring.test.tsnpm run lint:changednpm run buildnpm test -- --runInBand tests/cross-env/cursor-verification.test.ts(suite is skipped in this environment)Merge-after validation with OpenChrome
oc_recording_startwith{ "trajectoryBundle": true }.https://example.com, callread_page, run one passingoc_assert, save anoc_checkpoint, run one failingoc_assert, then calloc_recording_stop.meta.json,events.jsonl,contracts/,checkpoints/, andreport.json.jq -r '.seq' ~/.openchrome/trajectories/<id>/events.jsonl | awk 'NR>1 && $1<=prev { exit 1 } { prev=$1 }'.report.json.contracts.pass === 1,report.json.contracts.fail === 1, and checkpoint/contract artifact counts are non-zero.super-secret-fixture-passwordduring a recorded run and verify! grep -R "super-secret-fixture-password" ~/.openchrome/trajectories/<id>.trajectoryBundle:true; verify no new trajectory directory is created.Not tested