fix(tests): unblock tabs.test.ts — mock getTargetContextName + 5-arg createTarget#1121
Merged
Merged
Conversation
…createTarget Two regressions exposed by the #946 isolatedContext merge: 1. tests/utils/mock-session.ts — the mock SessionManager lacked `getTargetContextName()`, which the real implementation added in #946 and src/tools/tabs-context.ts now reads while building each TabInfo entry. Calling `undefined(targetId)` threw, silently caught by the surrounding try/catch, dropping the tab from the collected list. Stub the method as `jest.fn().mockReturnValue(undefined)` — tests do not exercise the named-context path, and the real method returns undefined for the default context too. 2. tests/tools/tabs.test.ts — the test's `toHaveBeenCalledWith` assertion for tabs_create.createTarget still listed only 4 args (sessionId, url, undefined, undefined). After #848/#946 the source passes a 5th `isolatedContext` arg. Update the two assertions to include the trailing undefined. Local: tests/tools/tabs.test.ts → 18/18 passing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks develop CI after #946 (isolatedContext) merge.
tests/utils/mock-session.ts— addgetTargetContextNamemock returningundefined.tests/tools/tabs.test.ts— update 2toHaveBeenCalledWithassertions to the new 5-argcreateTargetsignature.Local: 18/18 passing.
🤖 Generated with Claude Code