Scope network interception to MCP sessions#753
Open
shaun0927 wants to merge 1 commit into
Open
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Constraint: Preserve existing network_intercept block/modify behavior while preventing cross-session rule leakage. Rejected: Keep module-global activeRules | long-lived MCP processes can leak stale rules into unrelated sessions. Confidence: high Scope-risk: narrow Directive: Future per-rule removal should build on session-scoped interceptors rather than reintroducing module-global state. Tested: npm test -- --runTestsByPath tests/unit/network-interceptor.test.ts tests/unit/network-intercept-tool.test.ts; npm run lint -- --quiet src/tools/network-intercept.ts src/tools/network-offline.ts tests/unit/network-intercept-tool.test.ts; npm run build Not-tested: Live two-session Safari interception.
shaun0927
force-pushed
the
fix/752-session-network-intercept
branch
from
d8eef31 to
2ce07da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
network_interceptthrough the canonicalsrc/network-interceptor.tsimplementation.device_idtargeting and tests for session isolation / clear behavior.Closes #752.
Direction/scope review
block/modifyuser-facing actions and adds no dependencies.Verification
npm test -- --runTestsByPath tests/unit/network-interceptor.test.ts tests/unit/network-intercept-tool.test.tsnpm run lint -- --quiet src/tools/network-intercept.ts src/tools/network-offline.ts tests/unit/network-intercept-tool.test.tsnpm run buildLive validation after merge
modifyrule and confirm mocked fetch response.