Recover device_boot when WebKit registration is late#757
Open
shaun0927 wants to merge 1 commit into
Open
Conversation
Constraint: Live OpenSafari validation for #752 showed device_boot could return success while qa_session_create failed with NO_WEBKIT_CLIENT and diagnose reported device=null.\nRejected: Making WebKit mandatory for device_boot | native simulator tools should remain usable when Safari target discovery is temporarily unavailable.\nConfidence: high\nScope-risk: narrow\nDirective: Preserve best-effort boot semantics; surface WebKit unavailability through diagnostics instead of hiding a booted device.\nTested: npm test -- --runInBand tests/unit/device-boot-webkit-retry.test.ts; npm run lint -- --quiet; npm run build:src\nNot-tested: Full iOS WebKit live retry after installing this branch into the active MCP runtime.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionManagerbefore WebKit target discovery, so diagnostics/native tools still see the device when Safari is late or unavailable.Fixes #756.
Validation
npm test -- --runInBand tests/unit/device-boot-webkit-retry.test.tsnpm run lint -- --quietnpm run build:srcLive validation context
OpenSafari live validation on iPhone 16 (
3BEF4E9A-069A-4419-AC62-AB889348EF12) founddevice_bootreturning a proxy, followed byqa_session_create->NO_WEBKIT_CLIENTanddiagnose.device=null. This PR keeps the booted device diagnosable and retries a stale/late WebKit proxy once.