Reduce precision in outputs to eliminate floating point errors#18
Merged
shawest merged 2 commits intoshawest:masterfrom Feb 13, 2026
Merged
Conversation
This commit reduces the flakiness of the integration tests introduced in the previous commits by reducing the precision of NeucBOT's outputs. Currently, the outputs are formatted in scientific notation with 12+ digits after the decimal, which is well beyond the precision of these calculations. Even small changes to the NeucBOT code can create small differences in the outputs in these last decimal places due to errors produced by floating point aritmetic limitations, resulting in flaky integration tests that make it hard to tell if a regression is introduced. This commit solves this problem by making the following changes: - Installing the numpy package, which will be used in subsequent work - Rounds neucbot.py output values using numpy.format_float_scientific - Modifies tests/integration_tests.sh to produce better error messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reduces the flakiness of the integration tests introduced in the previous commits by reducing the precision of NeucBOT's outputs. Currently, the outputs are formatted in scientific notation with 12+ digits after the decimal, which is well beyond the precision of these calculations.
Even small changes to the NeucBOT code can create small differences in the outputs in these last decimal places due to errors produced by floating point aritmetic limitations, resulting in flaky integration tests that make it hard to tell if a regression is introduced. This commit solves this problem by making the following changes: