Alpha chain list + condense_alpha_list functionality#19
Merged
shawest merged 5 commits intoshawest:masterfrom Feb 13, 2026
Merged
Alpha chain list + condense_alpha_list functionality#19shawest merged 5 commits intoshawest:masterfrom
shawest merged 5 commits intoshawest:masterfrom
Conversation
This commit moves the loadChainAlphaList function from neucbot.py to neucbot/alpha.py and adds unit tests for this code.
This commit replaces the condense_alpha_list function with the AlphaList#condense() function in neucbot.py.
This change is intentional and is introduced to maintain parity with the current state of code in neucbot.py. Without this change, the calculated values differ significantly and the integration tests fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request continues to migrate code into the
neucbot.pypackage with the following changes:alpha.ChainListclass which can be used to handle creation of alpha lists fromChains/*.datfiles.condense_alpha_listfunction from neucbot.py to neucbot/alpha.py. This includes a minor performance improvement by generating the condensed alpha list in a more efficient manner. Previously, for each step in the range of(0, max_alpha), the entire list of alpha energies would be iterated over for each step to find the correct cumulative intensity. This PR keeps track of the current cumulative intensity with an incrementing index so that the alpha list doesn't need to be iterated over each time.