Merged
Conversation
This commit moves TALYS related code to neucbot/talys.py and makes a few improvements including: - Removing the creation of the unused runscript_f file - Using os.replace to replace existing nspec files
mpiercy827
force-pushed
the
talys-refactor
branch
from
c0f8efd to
d00466c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves TALYS related code to neucbot/talys.py and makes a few improvements including:
An integration test has been added to verify TALYS functionality, but it is currently commented out. In a subsequent PR, I'll work on getting
talysinstalled in the Github Action so that the test can be run there.