Skip to content

fix(homelab): disable invalid Minecraft Discord defaults - #3017

Merged
shepherdjerred merged 1 commit into
mainfrom
fix/minecraft-discord-runtime-defaults
Sep 21, 2026
Merged

shepherdjerred merged 1 commit into
mainfrom
fix/minecraft-discord-runtime-defaults

Conversation

@shepherdjerred

Copy link
Copy Markdown
Owner

Why
Mc2Discord generated an invalid status-channel registration and threw lifecycle formatter errors on server start/stop.

What
Disable lifecycle announcements and configure an empty optional status-channel list while retaining chat and info subscriptions.

Verification

  • Focused cdk8s container-resources test
  • cdk8s typecheck and lint
  • pre-commit package-quality checks
  • Live Discord-to-Minecraft relay test

@shepherdjerred

Copy link
Copy Markdown
Owner Author

This change is part of the following stack:

Change managed by git-spice.

@shepherdjerred
shepherdjerred force-pushed the fix/minecraft-discord-runtime-defaults branch from d79a741 to 3a7b10c Compare September 20, 2026 21:30
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-21T22:21:18.142768Z 7857916 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@shepherdjerred
shepherdjerred force-pushed the fix/minecraft-discord-runtime-defaults branch from 3a7b10c to 105ec07 Compare September 20, 2026 21:43
@shepherdjerred

Copy link
Copy Markdown
Owner Author

@codex review

Automated re-review request for 105ec07 from the CI review gate.

@shepherdjerred
shepherdjerred force-pushed the fix/minecraft-discord-runtime-defaults branch 3 times, most recently from e437934 to 30f2b36 Compare September 20, 2026 21:56
@shepherdjerred

Copy link
Copy Markdown
Owner Author

@codex review

Automated re-review request for e437934 from the CI review gate.

@shepherdjerred

Copy link
Copy Markdown
Owner Author

@codex review

Automated re-review request for 30f2b36 from the CI review gate.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 30f2b36e0b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@shepherdjerred

Copy link
Copy Markdown
Owner Author

@codex review

Automated re-review request for e437934 (attempt 2 of 2) from the CI review gate.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 30f2b36e0b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@shepherdjerred
shepherdjerred force-pushed the fix/minecraft-discord-runtime-defaults branch 3 times, most recently from 1920997 to c16ea2c Compare September 20, 2026 23:51
@shepherdjerred

Copy link
Copy Markdown
Owner Author

@codex review

Automated re-review request for 1920997 from the CI review gate.

@shepherdjerred

Copy link
Copy Markdown
Owner Author

@codex review

Automated re-review request for c16ea2c from the CI review gate.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: c16ea2c312

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@shepherdjerred

Copy link
Copy Markdown
Owner Author

@codex review

Automated re-review request for 1920997 (attempt 2 of 2) from the CI review gate.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c16ea2c312

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@shepherdjerred
shepherdjerred force-pushed the fix/minecraft-discord-runtime-defaults branch 2 times, most recently from 0b23d61 to 1665184 Compare September 21, 2026 00:44
@shepherdjerred

Copy link
Copy Markdown
Owner Author

@codex review

Automated re-review request for 0b23d61 from the CI review gate.

@shepherdjerred

Copy link
Copy Markdown
Owner Author

@codex review

Automated re-review request for 1665184 from the CI review gate.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 1665184f35

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@shepherdjerred

Copy link
Copy Markdown
Owner Author

@codex review

Automated re-review request for 0b23d61 (attempt 2 of 2) from the CI review gate.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 1665184f35

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@shepherdjerred
shepherdjerred force-pushed the fix/minecraft-discord-runtime-defaults branch from 1665184 to e847d1c Compare September 21, 2026 22:04
Why
Mc2Discord generated invalid optional status/lifecycle defaults, and the fresh RLCraft Dynmap landing page opened on an unrendered surface map at zoom 0.

What
Disable the invalid optional Mc2Discord status/lifecycle defaults while retaining chat and info subscriptions. Default Dynmap to the rendered flat overview at zoom 3.

Verification
Focused cdk8s tests, typecheck, lint, and pre-commit package-quality checks passed. Live Discord-to-Minecraft relay passed. Browser verification confirmed the rendered Dynmap view at the default-world centre.
@shepherdjerred
shepherdjerred force-pushed the fix/minecraft-discord-runtime-defaults branch from e847d1c to 7857916 Compare September 21, 2026 22:16
@shepherdjerred
shepherdjerred merged commit 65352bd into main Sep 21, 2026
7 checks passed
@shepherdjerred
shepherdjerred deleted the fix/minecraft-discord-runtime-defaults branch September 21, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant