Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vault 0.10.* in dev/testdev #434

Merged
merged 1 commit into from
Jul 16, 2018
Merged

vault 0.10.* in dev/testdev #434

merged 1 commit into from
Jul 16, 2018

Conversation

nbari
Copy link
Contributor

@nbari nbari commented Jul 16, 2018

add vault version 0.10.* to allow running make dev

@dmolik
Copy link
Contributor

dmolik commented Jul 16, 2018

Looks good to me, thank you!

@dmolik dmolik merged commit ad8df90 into shieldproject:master Jul 16, 2018
@jhunt
Copy link
Contributor

jhunt commented Jul 16, 2018

Umm... are we 100% sure that Vault 0.10.0's key-value backend will work with SHIELD? There was a reason we pinned at 0.9.6 and below.

@jhunt
Copy link
Contributor

jhunt commented Jul 16, 2018

Spoke with @dmolik privately, and he did test it locally on his dev environment before this PR was submitted. Perhaps only safe (egen/safe#138) has issues with Vault 0.10.0

@daviddob
Copy link
Contributor

I think this is due to the fact that SHIELD isn't using --dev for the vault and instead is using file backed storage. The new kv backend isn't automatically used as default outside of dev mode yet (not sure when they will make it default for non-dev servers or if they'll just wait till secret/ isn't a default mount anymore. Breaking change planned for Vault 0.12.X - secret/ will not be mounted by default at init time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants