Conversation
If you keep KEm in a folder on usb flash or desktop, you near-always expect that everything will live in this folder. If your KEm is somehow ended in C:\Program Files\, you probably don't want it to be portable, and windows won't allow you that anyway. So i deleted this flag and added checks against some well-knows paths.
Uses `open` on macos and XDG util on linux
For future installable packages. Not tested but should work in theory
This commit doesn't modify code.
Prompts to run with `sudo` or to use package manager.
|
Will close #96 |
Temporary "fix", watchers UX will be revisited separately
i ran out of ideas what else to touch, looks like ready one |
|
Also related to #95 |
| if (win) { | ||
| // installer will write to registry path to installed jar. Let's check it. | ||
| try { | ||
| Process regRequest = Runtime.getRuntime().exec("reg query \"HKEY_LOCAL_MACHINE\\Software\\nnproject\\KEmulator\" /v JarInstalledPath"); |
There was a problem hiding this comment.
How this will work on 32-bit systems/32-bit java?
There was a problem hiding this comment.
Because there is separate key for 32-bit apps on 64-bit systems: HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node
There was a problem hiding this comment.
This starts a separate process from 64-bit built-in util on pure-64 and WOW systems and from 32-bit on 32 systems. In theory, this will work if installer matches system's arch (MSI). If we will use third-party installer like NSIS, we will likely distribute 32-bit binary so it will fail on WOW systems (32-bit installer writes to 32-bit tree and 64-bit reg.exe checks 64-bit tree).
I suggest to leave this as is until i make installer and we will hit the fact that this check fails. Then i will fix it by adding /reg:32 argument.
There was a problem hiding this comment.
https://t.me/nnmidletschat_ru/179322
decided to leave as is
shinovon
force-pushed
the
linux-installation-preps
branch
from
7ad0667 to
ba04da1
Compare
2 participants
Simplifies handling of installed kem.