chore: enable govet linter #1825
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
golangci-lint/govet
branch
from
48747e9 to
57b4faf
Compare
|
I don't think there is a need for fieldalignment rule in govet linter. I'm assuming it's the root cause of so many changes. gopsutil is used on several OSes where alignment varies. So if you think there is a need for it, you could take a look at https://pkg.go.dev/structs#HostLayout (One of my recent discovery, thanks again @cristaloleg for this.) I would like to recommend you to either:
|
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
golangci-lint/govet
branch
from
57b4faf to
d93dd8a
Compare
mmorel-35
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
govetto the list of enabled linters in the Golang CI configuration