feat: Expand share dialog on iOS (#250) #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
Thanks a lot @DragonSpirit! The code looks good, except for two tiny nits about alphabetical ordering.
I'll find an iOS device to test this this week, and then we can merge.
amaury1093
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
Thanks a lot, this looks perfect. Btw I've updated the coding styleguide in CONTRIBUTING.md: https://github.com/amaurymartiny/shoot-i-smoke/blob/master/CONTRIBUTING.md#use-a-consistent-coding-style
|
Works well |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I improve iOS share menu like I show here. On android it's kind of difficult to implement in with expo, maybe it will work in future.
It would be great if you check in on physical device because I am android owner 😬