Skip to content

Modernize ConfirmActionDropdown to ConfirmActionModal#325

Open
abhijit9040 wants to merge 5 commits intoshopstr-eng:mainfrom
abhijit9040:main
Open

Modernize ConfirmActionDropdown to ConfirmActionModal#325
abhijit9040 wants to merge 5 commits intoshopstr-eng:mainfrom
abhijit9040:main

Conversation

@abhijit9040
Copy link
Copy Markdown
Contributor

This PR addresses the TODO in confirm-action-dropdown.tsx by refactoring the implementation to use a Modal pattern. This change improves user safety by making destructive actions (deletes/clears) explicit and centered in the UI.

Changes:

  • Replaced Dropdown with Modal from @nextui-org/react.
  • Renamed props to modern conventions (description, confirmLabel).
  • Updated usages in product-form.tsx, discount-codes.tsx, and display-product-modal.tsx.
  • Added a new, comprehensive test suite for the Modal component.
  • Removed the deprecated ConfirmActionDropdown file and associated TODO.

issue reference- #324

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 4, 2026

@abhijit9040 is attempting to deploy a commit to the shopstr-eng Team on Vercel.

A member of the Team first needs to authorize it.

@GautamBytes GautamBytes self-assigned this Apr 7, 2026
@GautamBytes
Copy link
Copy Markdown
Contributor

LGTM , Just try not to raise pr directly from origin main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants