feat: implement address management components and functionality#396
Open
Abhishek-Punhani wants to merge 5 commits intoshopstr-eng:mainfrom
Open
feat: implement address management components and functionality#396Abhishek-Punhani wants to merge 5 commits intoshopstr-eng:mainfrom
Abhishek-Punhani wants to merge 5 commits intoshopstr-eng:mainfrom
Conversation
|
@Abhishek-Punhani is attempting to deploy a commit to the shopstr-eng Team on Vercel. A member of the Team first needs to authorize it. |
- Add AddressPicker component for selecting and managing saved addresses. - Enhance PreferencesPage to include address management features. - Add unit tests for saved address helper functions. - Update local storage helper functions to manage saved addresses. - Define SavedAddress type in typescript types. Signed-off-by: Abhishek-Punhani <punhani.manavabhi@gmail.com>
…ress Signed-off-by: Abhishek-Punhani <punhani.manavabhi@gmail.com>
…s in preferences Signed-off-by: Abhishek-Punhani <punhani.manavabhi@gmail.com>
e49b203 to
0ef250f
Compare
0ef250f to
adc4620
Compare
arnavkirti
reviewed
Apr 11, 2026
Contributor
arnavkirti
left a comment
There was a problem hiding this comment.
Thanks for the solid work on this PR - Would like to point out some things:
- Please confirm that we validate all required fields (
name,address,city,state,zip,country) both on the client and at the boundary where these are sent to the backend. - Consider what happens if
ziporcountryare missing or malformed (especially for non‑US addresses) and add tests to cover these edge cases. isDefaultis a boolean onSavedAddress, but there is no obvious guard to ensure only one address can be default at a time.- Can you add logic (and tests) to ensure we never end up with multiple defaults, and clarify the behavior when the current default is deleted?
- Please double‑check that all interactive elements in the Address picker / management UI are keyboard accessible and have appropriate ARIA labels where needed.
- If we are showing destructive actions (like delete), a confirmation step or undo pattern would be helpful to prevent accidental loss of an address.
- it would be good to have a few focused tests on:
- Rendering of saved addresses list.
- Creating a new address and setting it as default.
- Editing/deleting an existing address.
- Ensuring only one default address after updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented address management components and functionality
Description
AddressPickercomponent for selecting and managing saved addresses.Use Saved Addressin cart view to use saved address during checkout.Resolved or fixed issue
Fixes #374
Screenshots (if applicable)
2026-04-10.23-17-11.mp4
Affirmation