Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic axe core asseccibility check #1441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kstala
Copy link
Collaborator

@kstala kstala commented Nov 11, 2024

Description

Adding basic accessibility tests using Ax Core for the home page, category and product page.
Adding a separate workflow for accessibility check.
Adding additional tag (accessibility)

Type of change

ToDo's

Screenshots (if applicable)

Additional context

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Nov 11, 2024 4:57pm
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Nov 11, 2024 4:57pm

Copy link

pkg-pr-new bot commented Nov 11, 2024

Open in Stackblitz

@shopware/api-client

pnpm add https://pkg.pr.new/shopware/frontends/@shopware/api-client@1441

@shopware/api-gen

pnpm add https://pkg.pr.new/shopware/frontends/@shopware/api-gen@1441

@shopware-pwa/cms-base

pnpm add https://pkg.pr.new/shopware/frontends/@shopware-pwa/cms-base@1441

@shopware-pwa/composables-next

pnpm add https://pkg.pr.new/shopware/frontends/@shopware-pwa/composables-next@1441

@shopware-pwa/nuxt3-module

pnpm add https://pkg.pr.new/shopware/frontends/@shopware-pwa/nuxt3-module@1441

@shopware-pwa/helpers-next

pnpm add https://pkg.pr.new/shopware/frontends/@shopware-pwa/helpers-next@1441

commit: 524bbe4

Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one thing to clarify

cache: "pnpm"
cache-dependency-path: "**/pnpm-lock.yaml"
- name: install
run: pnpm install --no-frozen-lockfile --prefer-offline
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why no frozen? It should probably install exact dependencies :)

Suggested change
run: pnpm install --no-frozen-lockfile --prefer-offline
run: pnpm install --frozen-lockfile --prefer-offline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants