-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add basic axe core asseccibility check #1441
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@shopware/api-client
@shopware/api-gen
@shopware-pwa/cms-base
@shopware-pwa/composables-next
@shopware-pwa/nuxt3-module
@shopware-pwa/helpers-next
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one thing to clarify
cache: "pnpm" | ||
cache-dependency-path: "**/pnpm-lock.yaml" | ||
- name: install | ||
run: pnpm install --no-frozen-lockfile --prefer-offline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why no frozen
? It should probably install exact dependencies :)
run: pnpm install --no-frozen-lockfile --prefer-offline | |
run: pnpm install --frozen-lockfile --prefer-offline |
Description
Adding basic accessibility tests using Ax Core for the home page, category and product page.
Adding a separate workflow for accessibility check.
Adding additional tag (accessibility)
Type of change
ToDo's
Screenshots (if applicable)
Additional context