Skip to content

SG-40026 Fix misused super in CACertsHTTPSConnection and CACertsHTTPSHandler #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SG-40026 Fix misused super in CACertsHTTPSConnection and CACertsHTTPSHandler #394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions shotgun_api3/shotgun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4678,11 +4678,11 @@ def __init__(self, *args, **kwargs):
"""
# Pop that argument,
self.__ca_certs = kwargs.pop("ca_certs")
super().__init__(self, *args, **kwargs)
super().__init__(*args, **kwargs)

def connect(self):
"Connect to a host on a given (SSL) port."
super().connect(self)
super().connect()
# Now that the regular HTTP socket has been created, wrap it with our SSL certs.
if six.PY38:
context = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)
Expand All @@ -4697,13 +4697,13 @@ def connect(self):
)


class CACertsHTTPSHandler(urllib.request.HTTPHandler):
class CACertsHTTPSHandler(urllib.request.HTTPSHandler):
"""
Handler that ensures https connections are created with the custom CA certs.
"""

def __init__(self, cacerts):
super().__init__(self)
super().__init__()
self.__ca_certs = cacerts

def https_open(self, req):
Expand Down
Loading