SG-39414 Add type annotations #422
Conversation
| """ | ||
|
|
||
| import datetime | ||
| from typing import Any |
There was a problem hiding this comment.
I don't like using things from outside without having a package/module name.
| from typing import Any | |
| import typing |
Then use typing.Any.
If you are looking for a short version, we can always aggree on
import typing as tpThere was a problem hiding this comment.
This is a subjective personal preference, and we cannot enforce this. I agree on being explicit and importing the objects specifically.
|
|
||
| @classmethod | ||
| def get_schemas(cls, schema_path, schema_entity_path): | ||
| def get_schemas(cls, schema_path: str, schema_entity_path: str) -> tuple: |
There was a problem hiding this comment.
return value: tuple of what? Can we define string/int/dict/... ?
There was a problem hiding this comment.
We'll leave it as is, since it's a unit testing helper method. Not everything in Mockgun has been typed so far.
| direction: str | ||
|
|
||
|
|
||
| class BaseEntity(TypedDict, total=False): |
There was a problem hiding this comment.
what is this total=False syntax? I never saw that
There was a problem hiding this comment.
It means that we don't expect to require all the defined fields.
Closes #393
Thanks @chadrik