Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHOT-4398: Fix proxy server handling #208

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

staceyoue
Copy link
Contributor

@staceyoue staceyoue commented Feb 5, 2025

  • Set the http session to disable proxy by default
  • Add env var to optionally enable/disable proxy

Requires shotgunsoftware/tk-framework-alias#83

@staceyoue staceyoue requested a review from a team February 5, 2025 21:30
Copy link
Contributor

@julien-lang julien-lang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But we need to document this env var.

Could be either https://developers.shotgridsoftware.com/tk-alias/ or https://help.autodesk.com/view/SGDEV/ENU/?guid=SGD_pc_engine_alias_html

Where do you think would be best?

engine.py Outdated Show resolved Hide resolved
@staceyoue
Copy link
Contributor Author

staceyoue commented Feb 6, 2025

Looks good to me. But we need to document this env var.

Could be either https://developers.shotgridsoftware.com/tk-alias/ or https://help.autodesk.com/view/SGDEV/ENU/?guid=SGD_pc_engine_alias_html

Where do you think would be best?

@julien-lang I think I'd prefer https://developers.shotgridsoftware.com/tk-alias, but only because we tend to keep this more up to date than the other page

* Add missing v4.1.3 to what's changed
* Add new v4.1.4 to what's changed
* Add troublshotting docs
* Add env var docs
@staceyoue staceyoue requested a review from julien-lang February 6, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants