#29975 add app_path, app_args, version params to before_app_launch hook #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The before_app_launch hook now gets the same parameters as the app_launch hook which means you have access to the path of the application being launched and any arguments passed in. Also added a version parameter which will contain the version being launched *if* it was defined in the "versions" setting in the Launcher instance (otherwise this will be None).
| this will be None. | ||
| """ | ||
| if version is None: | ||
| return version |
There was a problem hiding this comment.
Very minor but I think this would be clearer if it was 'return None'
|
One very minor comment but otherwise looks good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
before_app_launchhook now gets the same parameters as theapp_launchhook which means you have access to the path of the application being launched and any arguments passed in. Also added aversionparameter which will contain the version being launched if it was defined in the"versions"setting in the Launcher instance (otherwise this will beNone).