Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hookify software_entity_launcher and single_config_launcher #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kramester
Copy link

I converted the BaseLauncher class into a base hook and made the subclasses SingleConfigLauncher and SoftwareEntityLaunchers into hooks. This way a developer can completely replace the logic here with their own launcher code. The app remains intact and works the exact same as before but this deprecates the need for the use_software_entity bool setting and instead uses a hook_launcher hook setting to determine which launcher to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant