hookify software_entity_launcher and single_config_launcher #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I converted the
BaseLauncher
class into a base hook and made the subclassesSingleConfigLauncher
andSoftwareEntityLaunchers
into hooks. This way a developer can completely replace the logic here with their own launcher code. The app remains intact and works the exact same as before but this deprecates the need for theuse_software_entity
bool setting and instead uses ahook_launcher
hook setting to determine which launcher to use.