feat: add progress spinner to check, list, and update commands#88
Merged
shreyasmene06 merged 8 commits intoMay 17, 2026
Merged
Conversation
- Uses rich console.status() spinner during network fetches - pyvm check shows spinner while fetching latest version info - pyvm list shows spinner while fetching releases - pyvm update shows spinner while checking for updates - Spinner clears before printing results for clean output - Adds 6 tests verifying spinner behavior Closes shreyasmene06#82
…mpatibility - ✓ → [OK] - ⚠ → [!] - 💡 → [*] - ❌ → [X] - ✅ → [OK] - 🚀 → [>] - 📌 → [*] - 📊 → [=] - 🖥️ → [PC] - 🩺 → [?] - ℹ️ → [i] - ✗ → [X] - 🎉 → [*]
shreyasmene06
requested changes
May 15, 2026
Owner
shreyasmene06
left a comment
shreyasmene06
left a comment
There was a problem hiding this comment.
@swarnimbandekar please make sure the checks are passed
shreyasmene06
requested changes
May 16, 2026
Owner
shreyasmene06
left a comment
shreyasmene06
left a comment
There was a problem hiding this comment.
Thanks for the PR - the spinner UX direction looks good.
I’m requesting changes for two reasons before merge:
- Functional issue in check: it now calls check_python_version(silent=True) and prints success when needs_update is
false, but on fetch failure that function returns (local_ver, None, False). This can show Latest version: None and still
report up-to-date. Please handle latest_ver is None explicitly (error message + non-zero exit), like existing behavior. - Scope drift for issue #82: this PR also changes many unrelated status messages/emojis across commands. Please keep
this PR focused on spinner behavior for check (and if intended, list/update) and move formatting-wide changes to a separate
PR.
Please also add/update a test covering the check fetch-failure path so this doesn’t regress again.
- Integrate rich.Console spinners for check, list, update commands - Handle fetch failure in check with explicit error + non-zero exit - Preserve --json flag from upstream using nullcontext to skip spinner - Fix test_check_json_network_failure to expect exit code 1 on None - Update README with spinner feature mention
Contributor
Author
Summary
All improvements maintain user experience and project scope while enhancing test coverage and discoverability |
shreyasmene06
approved these changes
May 17, 2026
Owner
shreyasmene06
left a comment
shreyasmene06
left a comment
There was a problem hiding this comment.
LGTM!
Thank you for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #82
GSSoC26