Skip to content

fix: fix precision bug in parseFloat affecting select(DOUBLE) in prepared statements #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+5 −33
Open

fix: fix precision bug in parseFloat affecting select(DOUBLE) in prepared statements #1527

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3890bba
Fix precision bug in parseFloat affecting select(DOUBLE) in prepared …
Mar 1, 2022
8669cc6
packet.js - style nit to minimize diff
Mar 1, 2022
f4698d2
packet.js parseFloat - eliminate unnecessary Buffer.slice()
Mar 2, 2022
5444909
Merge branch 'master' into wesgarland/issue-1525-parse-float
wellwelwel Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 5 additions & 33 deletions lib/packets/packet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@
const plus = '+'.charCodeAt(0);

// TODO: handle E notation
const dot = '.'.charCodeAt(0);

Check failure on line 43 in lib/packets/packet.js

View workflow job for this annotation

GitHub Actions / lint-js 

'dot' is assigned a value but never used
const exponent = 'e'.charCodeAt(0);

Check failure on line 44 in lib/packets/packet.js

View workflow job for this annotation

GitHub Actions / lint-js 

'exponent' is assigned a value but never used
const exponentCapital = 'E'.charCodeAt(0);

Check failure on line 45 in lib/packets/packet.js

View workflow job for this annotation

GitHub Actions / lint-js 

'exponentCapital' is assigned a value but never used

class Packet {
constructor(id, buffer, start, end) {
Expand Down Expand Up @@ -658,43 +658,15 @@
}

parseFloat(len) {
if (len === null) {
return null;
}
let result = 0;
const start = this.offset;
const end = this.offset + len;
let factor = 1;
let pastDot = false;
let charCode = 0;
this.offset += len;

if (len === 0) {
return 0; // TODO: assert? exception?
}
if (this.buffer[this.offset] === minus) {
this.offset++;
factor = -1;
}
if (this.buffer[this.offset] === plus) {
this.offset++; // just ignore
}
while (this.offset < end) {
charCode = this.buffer[this.offset];
if (charCode === dot) {
pastDot = true;
this.offset++;
} else if (charCode === exponent || charCode === exponentCapital) {
this.offset++;
const exponentValue = this.parseInt(end - this.offset);
return (result / factor) * Math.pow(10, exponentValue);
} else {
result *= 10;
result += this.buffer[this.offset] - 48;
this.offset++;
if (pastDot) {
factor = factor * 10;
}
}
}
return result / factor;

return parseFloat(this.buffer.toString('ascii', start, end));
}

parseLengthCodedIntNoBigCheck() {
Expand Down
Loading