Conversation
There was a problem hiding this comment.
Code Review
This pull request attempts to add functionality to hide the siTooltip directive when the Escape key is pressed. However, the current implementation using a (keydown.escape) host listener is not fully effective as it only works when the directive's element has focus. A more robust solution is suggested, involving listening for global Escape key events within the TooltipRef service using Angular CDK's OverlayRef to ensure the tooltip can be dismissed regardless of focus.
4c667e6 to
30f6c28
Compare
0b630d6 to
8c5ee80
Compare
8c5ee80 to
c00134b
Compare
Done. It seems that the navbar expects the tooltip to be open when the menu is closed in one of the tests. The test is failing. because the escape would call the hide() and close the tooltip. So now we check if the tooltip was even visible before calling the hide |
https://www.w3.org/WAI/ARIA/apg/patterns/tooltip/
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: