fix(core/button): support added for form attribute in ix-button #1793

GayatriK2002 · 2025-03-24T06:14:41Z

💡 What is the current behavior?

Form attribute support was not available for ix-button.
Issue with submitting the form using form ID when the submit button is outside the form.

GitHub Issue Number: #1653

🆕 What is the new behavior?

Form attribute support added in ix-button.
Now form can be submitted using form ID when passed to form attribute.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

🦮 Accessibility (a11y) features were implemented
🗺️ Internationalization (i18n) - no hard coded strings
📲 Responsiveness - components handle viewport changes and content overflow gracefully
📄 Documentation was reviewed/updated (pnpm run docs)
🧪 Unit tests were added/updated and pass (pnpm test)
📸 Visual regression tests were added/updated and pass (Guide)
🧐 Static code analysis passes (pnpm lint)
🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

…g-ix-button

changeset-bot · 2025-03-24T06:14:45Z

⚠️ No Changeset found

Latest commit: d68eaba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

packages/core/src/components/button/button.tsx

.github/workflows/issue-contribution-welcome.yml

.github/workflows/issue-needs-repo.yml

.github/workflows/issue-workflow.yml

danielleroux

You added framework integrations but missed the html-test-app

packages/angular-test-app/src/preview-examples/modal-form-ix-button-submit.ts

packages/core/src/components/button/button.tsx

packages/vue-test-app/src/Root.vue

packages/core/src/components/button/button.tsx

packages/react-test-app/src/preview-examples/modal-form-ix-button-submit.tsx

packages/vue-test-app/src/preview-examples/modal-form-ix-button-submit.vue

packages/html-test-app/src/preview-examples/modal-form-ix-button-submit.html

packages/angular-test-app/src/preview-examples/modal-form-ix-button-submit.html

packages/core/src/components/button/button.tsx

packages/angular-test-app/src/preview-examples/modal-form-ix-button-submit.html

danielleroux · 2025-04-10T11:46:03Z

packages/angular-test-app/src/preview-examples/modal-form-ix-button-submit.html

+        id="create-resource-form"
+        #formRef="ngForm"
+        class="form"


Which purpose has this class here?

@GayatriK2002 this was not addressed yet

packages/react-test-app/src/preview-examples/modal-form-ix-button-submit.tsx

danielleroux · 2025-04-10T11:48:09Z

@GayatriK2002 In general looks good, but please review the test app examples remove unnecessary classes and align this through the other examples also

packages/angular-test-app/src/preview-examples/modal-form-ix-button-submit.ts

danielleroux · 2025-04-16T09:05:36Z

packages/angular-test-app/src/preview-examples/modal-form-ix-button-submit.html

+        <div>
+          <ix-input label="Name:" type="text" name="name" ngModel></ix-input>
+        </div>


Suggested change

<div>

<ix-input label="Name:" type="text" name="name" ngModel></ix-input>

</div>

<ix-input label="Name:" type="text" name="name" ngModel></ix-input>

Why do we need this additional element around? Same happens inside other examples too

sonarqubecloud · 2025-04-16T09:57:00Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

GayatriK2002 added 2 commits March 22, 2025 17:16

ixbutton: fix-1653/form-submition-support-using-ix-button issue fix

a80006a

Merge branch 'siemens:main' into fix-1653/form-submition-support-usin…

367e1cd

…g-ix-button

GayatriK2002 added 3 commits March 24, 2025 13:48

sonarQube error fix

5bbe96e

solarqube error fix

432623d

solarQube error fix

9168e3f

raghu-siemens reviewed Mar 24, 2025

View reviewed changes

packages/core/src/components/button/button.tsx Outdated Show resolved Hide resolved

Comment in PR viewed and implimented

6765afc

GayatriK2002 marked this pull request as ready for review March 24, 2025 11:21

danielleroux requested changes Mar 24, 2025

View reviewed changes

.github/workflows/issue-contribution-welcome.yml Outdated Show resolved Hide resolved

.github/workflows/issue-needs-repo.yml Outdated Show resolved Hide resolved

.github/workflows/issue-workflow.yml Outdated Show resolved Hide resolved

GayatriK2002 added 2 commits March 24, 2025 19:15

Implemented changes commented in PR Draft

c443f74

Reverted back the changes mentioned in Comment about sha change

4b74d59

danielleroux reviewed Mar 26, 2025

View reviewed changes

.github/workflows/issue-workflow.yml Outdated Show resolved Hide resolved

danielleroux requested changes Mar 26, 2025

View reviewed changes

Merge branch 'main' into fix-1653/form-submition-support-using-ix-button

b7990b5

nuke-ellington requested changes Mar 27, 2025

View reviewed changes

packages/core/src/components/button/button.tsx Outdated Show resolved Hide resolved

packages/core/src/components/button/button.tsx Outdated Show resolved Hide resolved

GayatriK2002 added 6 commits March 27, 2025 16:20

dispatchFormEvents updated

b903077

sonarQube changes

05504fc

Modified test case for form submit ix-button

2574b58

Merge branch 'main' into fix-1653/form-submition-support-using-ix-button

c97672e

Merge branch 'main' into fix-1653/form-submition-support-using-ix-button

68c070d

Merge branch 'main' into fix-1653/form-submition-support-using-ix-button

84759fe

danielleroux requested changes Apr 7, 2025

View reviewed changes

GayatriK2002 added 3 commits April 8, 2025 10:19

Merge branch 'main' into fix-1653/form-submition-support-using-ix-button

cb8d58e

Modified preview examples with ix-input

e2cac10

suggestion implemented in button.tsx

fda4b05

GayatriK2002 requested a review from danielleroux April 10, 2025 05:34

danielleroux reviewed Apr 10, 2025

View reviewed changes

packages/angular-test-app/src/preview-examples/modal-form-ix-button-submit.html Outdated Show resolved Hide resolved

danielleroux reviewed Apr 10, 2025

View reviewed changes

packages/react-test-app/src/preview-examples/modal-form-ix-button-submit.tsx Outdated Show resolved Hide resolved

GayatriK2002 added 2 commits April 15, 2025 11:17

Merge branch 'main' into fix-1653/form-submition-support-using-ix-button

1a9a47b

Updated preview-examples

031135e

nuke-ellington reviewed Apr 15, 2025

View reviewed changes

packages/angular-test-app/src/preview-examples/modal-form-ix-button-submit.ts Outdated Show resolved Hide resolved

GayatriK2002 added 2 commits April 15, 2025 14:15

Removed unnecessary 'instance' variable in angular preview-example

d227667

Merge branch 'main' into fix-1653/form-submition-support-using-ix-button

5234c47

danielleroux requested changes Apr 16, 2025

View reviewed changes

removed <div> around ix-input and unnecessary classes

d68eaba

GayatriK2002 requested a review from danielleroux April 17, 2025 08:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core/button): support added for form attribute in ix-button #1793

fix(core/button): support added for form attribute in ix-button #1793

GayatriK2002 commented Mar 24, 2025 •

edited

Loading

changeset-bot bot commented Mar 24, 2025 •

edited

Loading

danielleroux left a comment

danielleroux Apr 10, 2025

GayatriK2002 Apr 16, 2025

nuke-ellington Apr 16, 2025

danielleroux commented Apr 10, 2025

danielleroux Apr 16, 2025

GayatriK2002 Apr 16, 2025

sonarqubecloud bot commented Apr 16, 2025

fix(core/button): support added for form attribute in ix-button #1793

Are you sure you want to change the base?

fix(core/button): support added for form attribute in ix-button #1793

Conversation

GayatriK2002 commented Mar 24, 2025 • edited Loading

💡 What is the current behavior?

🆕 What is the new behavior?

🏁 Checklist

👨‍💻 Help & support

changeset-bot bot commented Mar 24, 2025 • edited Loading

⚠️ No Changeset found

danielleroux left a comment

Choose a reason for hiding this comment

danielleroux Apr 10, 2025

Choose a reason for hiding this comment

GayatriK2002 Apr 16, 2025

Choose a reason for hiding this comment

nuke-ellington Apr 16, 2025

Choose a reason for hiding this comment

danielleroux commented Apr 10, 2025

danielleroux Apr 16, 2025

Choose a reason for hiding this comment

GayatriK2002 Apr 16, 2025

Choose a reason for hiding this comment

sonarqubecloud bot commented Apr 16, 2025

Quality Gate passed

GayatriK2002 commented Mar 24, 2025 •

edited

Loading

changeset-bot bot commented Mar 24, 2025 •

edited

Loading